Update instructions for importing game.dart#13249
Update instructions for importing game.dart#13249surfmuggle wants to merge 2 commits intoflutter:mainfrom
Conversation
Clarified instructions for importing game.dart in main.dart.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the widget fundamentals tutorial documentation to provide more detailed instructions for importing the game logic file into the main application. A review comment identifies a line exceeding the 80-character limit for semantic line breaks and suggests splitting it for better readability and style compliance.
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Breaking up the line, otherwise, lgtm. Thanks for this, @surfmuggle!
|
/gcbrun |
|
@surfmuggle, thanks for this PR! Can you sign the CLA? I can't land this until you do. Thx! |
sfshaza2
added
the
cla: no
|
Visit the preview URL for this PR (updated for commit dbde832): |
I tried but since i am not really using any google auth service it did not work right away. Can i sign anything here on github? This would make it much easier. |
|
@surfmuggle, this page has more details, did you check that? View this failed invocation of the CLA check for more information. |
|
The link failed invocation points to https://cla.developers.google.com/about
To my understanding: I would have to set up a google account, possibly register a gmail or at least provide my own email and so on. Suggestion: close - won't merge |
|
I understand, @surfmuggle! Thanks, anyway! |
3 participants
Clarified instructions for importing game.dart in main.dart.
Presubmit checklist
of 80 characters or fewer.